SAS7BDAT parser: Speed up blank_missing #48502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 12, 2022
| @@ -9,6 +9,8 @@ ctypedef signed long long int64_t | |||
| ctypedef unsigned char uint8_t | |||
| ctypedef unsigned short uint16_t | |||
|
|
|||
| cdef object np_nan = np.nan | |||
There was a problem hiding this comment.
Still needed? (np.nan is just used below)
There was a problem hiding this comment.
Good catch, it was meant to be used (the np.nan lookup is quite slow)
mroeschke
added
Performance
mroeschke
approved these changes
Sep 13, 2022
|
Thanks @jonashaag |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* SAS7BDAT parser: Speed up blank_missing * Add what's new * Fix issue no * Update v1.6.0.rst * Update sas.pyx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
blank_missingto Cython.ASV:
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.